Yes, I just installed the DiploMod 3.3 and am running CTP2 1.11 -- and I cant get past one turn without that error message.

Something is a bit amiss. I hope this helps you to know that there are probably a good many of us having this... and hopefully you can isolate the issue and fix. For now I probably have to go back to the lame default diplomacy.. means reinstalling (ick..)

Thanks!

Firstly, I'd like some feedback as to whether the following errors are only isolated in Med Mod, the non-Med Mod version, or both. This will help in debuging because I can go to the specifics.

Here is my configuration:
Win2000 Pro, DirectX 8, P3 666, 128 RAM, installed "FULL" to E: (ahhh the beauty of a 40GB HDD). I'm running Asia-Pacific with patch 1.11.

I get none of these crash errors, and can't even re-create them on my setup.

If anyone is in Melbourne getting these errors, maybe we could work something out.

1. DIP_MainRoutine, function _ConsiderNewProposal: Wrong Type of Argument

- Open diplomod.slc in notepad and scroll down till you find the following. Then comment these lines out (put // in front):

code:

---

// if(DIP_request == 7) {
//      for(DIP_tmpvalue2 = 1; DIP_tmpvalue2 < DIP_NumOfPlayers; DIP_tmpvalue2 = DIP_tmpvalue2 + 1) {
//		if(DIP_tmpvalue2 != player[0]) {
//			ConsiderNewProposal(player[0], player[1], DIP_requestpriority, 7, DIP_tmpvalue2, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS);
//		}
//	}
// }
// if(DIP_request == 8) {
//	for(DIP_tmpvalue2 = 1; DIP_tmpvalue2 < DIP_NumOfPlayers; DIP_tmpvalue2 = DIP_tmpvalue2 + 1) {
//		if(DIP_tmpvalue2 != player[0]) {
//			ConsiderNewProposal(player[0], player[1], DIP_requestpriority, 8, DIP_tmpvalue2, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS);
//		}
//	}
// }

---

2. mm2_diplomod.slc:151:Array index 13 out of bounds (or other various numbers).
- This refers to a "for" loop which cycles through each civ in the game and checks to see if an embassy re-create is required. Try changing the code to this:

code:

---

///////////////////////////////////
// Check embassy routine
///////////////////////////////////
 
HandleEvent(BeginTurn) 'DIP_EmbassyCheck' pre {
	int_t civ;
	int_t civ3;
        civ3 = 0;
	civ = player[0];
	for(civ3; civ3 < DIP_NumOfPlayers; civ3 = civ3 + 1) {
		if((AtWarWith(civ, civ3)) && DIP_hasemb[(DIP_NumOfPlayers * civ) + civ3] == 1) {
			DIP_hasemb[(DIP_NumOfPlayers * civ) + civ3] = 0;
			DIP_hademb[(DIP_NumOfPlayers * civ) + civ3] = 1;
		}
		if(DIP_hasemb[(DIP_NumOfPlayers * civ) + civ3] == 0 && DIP_hademb[(DIP_NumOfPlayers * civ) + civ3] == 1 && !(AtWarWith(civ, civ3))) {
			DIP_EstablishEmbassyFunc(civ3);
		}
	}
}

---

Well, this is pretty much all I can think of right now to help you guys. Remember, I need to know if the V3.3 non-Med Mod version is creating these errors as well?

Also, is anyone having problems using scenarios with diplomod? I've had a report of errors relating to DIPLOMACY_AI_AI not in DiplomacyDB.

code:

---

if(DIP_request == 7) {
	for(DIP_tmpvalue2 = 1; DIP_tmpvalue2 < DIP_NumOfPlayers; DIP_tmpvalue2 = DIP_tmpvalue2 + 1) {
		if(DIP_tmpvalue2 != player[0] && DIP_tmpvalue2 != player[1]) {
			ConsiderNewProposal(player[0], player[1], DIP_requestpriority, 7, DIP_tmpvalue2, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS);
		}
	}
}
if(DIP_request == 8) {
	for(DIP_tmpvalue2 = 1; DIP_tmpvalue2 < DIP_NumOfPlayers; DIP_tmpvalue2 = DIP_tmpvalue2 + 1) {
		if(DIP_tmpvalue2 != player[0] && DIP_tmpvalue2 != player[1]) {
			ConsiderNewProposal(player[0], player[1], DIP_requestpriority, 8, DIP_tmpvalue2, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS, ID_AIS_LOVE_AIS);
		}
	}
}

---

Only the two lines "if(DIP_tmpvalue2 !=......." have changed in this attempt.

Just remember though, you'll just need to bare with me as I experiment, and will need help from you guys to fix these. Thanks for ya support though.

Just a curious question here, but is there anyone like me who's NOT having a problem with V3.3?

The new code for the diplomacy main routine seems to work..i.e. no more "wrong argument" errors.

When replacing the embassy code, however, MM2 won't even start up - it reverts back to the desktop and tells me it's having a syntax error.

btw - these errors seem to be exclusive to MM2. Diplomod v3.3 runs fine in normal games.

Dale -- I am getting the "Wrong Type of Argument" message and I do NOT have the MM2 mod installed. Just a plain CTP2 version 1.11 with your DiploMod 3.3 applied.

North American version (I'm in New York state) - PIII at 600MHZ and 384MB Ram.

Hope that helps. I havent tried to remove the code as the workaround yet. I will try later and let you all know if it works for me.

Running 233 Mhz, on a 48meg machine. DirectX 7. 12 meg video card. Installed full to directory D.

Further, the game I play is Medium level, 5 races, Medium size.

Uh... Music on?

Well Removing the codes for 7 and 8 (as Dale suggested in one thread) seemed to have cleared up the problem. So now I can play again! Thanks ... but hopefully the solution doesnt really affect the overall improvement in the DiploMod.

I believe I have a solution to the array out of bounds errors. Around line 70 in MM2_Diplomod.slc, you will find an event handler called "DIP_BeginGame". After the line:

DIP_turns = 0;

add the lines:

DIP_hasemb[DIP_NumOfPlayers*DIP_NumOfPlayers] = 0;
DIP_hademb[DIP_NumOfPlayers*DIP_NumOfPlayers] = 0;

The problem may go away

Only made this one change and put the "Check Embassy" code back to the original setting and the game is now working. Had to stop - something about having to go to work.

On the weekend I spent hours trying out various things to recreate the problems you guys have mentioned. I couldn't recreate the problems. So yesterday I went through and disabled the break agreements proposals and comment-out the re-creating of embassies code. I called this V3.4. It looks like I don't need to do this.

So let me get this straight:
1. Add to the "BeginGame" routine.
DIP_hasemb[DIP_NumOfPlayers*DIP_NumOfPlayers] = 0;
DIP_hademb[DIP_NumOfPlayers*DIP_NumOfPlayers] = 0;
2. Leave the "Check Embassy" code as per original.
3. Delete userprofile.txt and let CTP2 recreate it.

This will elliminate the errors? I need confirmation so I can put it into the readme.txt file.

quote: Originally posted by Dale on 03-12-2001 10:03 PM 3. Delete userprofile.txt and let CTP2 recreate it.

No, this won't eliminate the errors. It may make the SLIC errors visable to anyone who hasn't been seeing them.

I'm assuming that when I set debugSLIC to 'no' in userprofile.txt that the errors still occur, but CtP2 won't report them to me. What baffles me is that, when I reset debugSLIC to 'yes', why aren't the SLIC errors reported?

Some flag in some file (not userprofile.txt!) must get set when debugSLIC is set to 'no', but doesn't get reset when debugSLIC is subsequently changed. I'm guessing that when CtP sees userprofile.txt is not there, it goes through some initialization process that properly sets this mysterious flag.

For the "wrong arguement" errors for proposal 7 & 8, have you tried changing the compare line in both to this? I heard someone had success doing that.

if(DIP_tmpvalue2 != player[0] && DIP_tmpvalue2 != player[1]) {

It a catch I should have seen from the begining. Stupid me.

I believe I have tried adding the conditional with no success. I will try again later to verify.

Where there is an "island" of explored territory that would imply that the two AI-civs never actually met. Is this just an area of the game where the AI is playing by different rules?

I am getting this error:

In object DIP_MainRoutine, function_ConsiderNewProposal: wrong type of argument.

I am running The MedMod II on a PIII 700, 30GB hard drive, and 192MB Ram.
And I do have the 1.11 Patch installed.

I just discovered this, I one of the errors for each of the other civs turns, not including the barbarians. I am currently playing with 4 civs. Each time I clear the error and get back into the game it is the next civs turn, then it gives me the error again on the next civ. Once it gets to my turn I take my turn then it does it all over again for the otehr civs. I hope this helps some! I just wanted to say thanks for working so hard on this! It's nice to have somebody working hard to make this game good! (obviously I don't mean Activision!)

Time flies like the wind, house flies like the wall.

Thanks, I must have missed that part about commenting those parts out. Sorry! I'm kind of new to the forum so I forget to check the previous messages! I'll be looking forwards to the new Med Mod update!

Also, in related news, I've sent Diplomod V3.4 (the official release not the Med Mod II release) to Omnigod to update the files DB with. It has exactly the same functionality as the MM2 version. Which means re-creating embassies and disabling break agreement proposals changes from V3.3.

Hope you guys continue to enjoy the mod.

Dale

Ehhmmm, it's 19th of march here and the file DB still says 3.3, what's the matter ???

Furthermore, could the medmod use another SLIC file for creating pirates on the oceans...I'm working on one !

Let me know !

See ya

As for the normal diplomacy mod 3.4, if you or anyone else wants it, just email me and I'll email it back.