1. Here is my code that should stop the people from buliding in Locations Dummy and Dummy2 which are defined elsewhere. To me the code looks good. Why doesnt it stop me from building cities and show a message?

code:

---

HandleEvent(CreateCity) 'WWCreateCity_F' pre {
	int_t m;		// Used for loop
	int_t tmpNum;		// How many units in the civilization
	
	unit_t tmpUnit;		// Used to see if unit lands on land
	player[0] = 0;
	tmpNum = player[0].units;
	for(m = 0; m < tmpNum; m = m + 1){
		GetUnitByIndex(player[0], m, tmpUnit);
		if (tmpUnit == UnitDB(UNIT_SETTLER) | | tmpUnit == UnitDB(UNIT_SEA_ENGINEER) | | tmpUnit == UnitDB(UNIT_URBAN_PLANNER)){ 
			if (tmpUnit.Location == Dummy | | tmpUnit.Location == Dummy2){
				Message (g.player, 'WWTerrainRecommend');
				return STOP;
			}
			else {
				return 0;
			}
		}
	}
}

---

2. Here is some non-working code that should display a messagebox when you bulid in location Dummy3, but alas it is also not working.

code:

---

HandleEvent(CreateCity) 'WWCreateCity2_F' post {
	location_t tmpLocation;		// Used for the Dummy locations
	city_t tmpCity;			// Used as the variable for city index
		
	int_t m;			// Used for loop
	//Use the following to check whether the player creates a land city	
	for(m = 0; m < player[0].cities; m = m + 1){
		GetCityByIndex(player[0], m, tmpCity);
		if(CityIsValid(tmpCity)) {
			if(tmpCity.Location == Dummy3){			
				if(turnCount > 101 ){
					playerScore = playerScore + 1000;  // Max Score!!
					hasCity = 1;
					Message (g.player, 'WWCityBuilt');
				}
				elseif(turnCount > 204){
					playerScore = playerScore + 750;
					hasCity =1;
					Message (g.player, 'WWCityBuilt2');
				}
				elseif(turnCount > 307){
					playerScore = playerScore + 500;
					hasCity =1;
					Message (g.player, 'WWCityBuilt3');
				}
			}
		}
	}	
	
}

---

3. Finally (and this one doesnt evene look like it is close to being correct) code that should display a message box when you first arrive on the 3 land tiles (dummy, dummy2 and dummy3)

code:

---

HandleEvent(MoveArmy) 'WWMoveUnits_F' post {
	
	int_t m;		// Used for loop
	int_t tmpNum;		// How many units in the civilization
	
	army_t tmpArmy;		// Used to see if unit lands on land
	// If Units land on land terrain
	
	player[0] = 0;
	tmpNum = player[0].units;
	for(m = 0; m < tmpNum; m = m + 1){
		GetArmyByIndex(player[0], m, tmpArmy);
		if(isCityThere == 1) {
			if(tmpArmy.Location == Dummy | | tmpArmy.Location == Dummy2 | | tmpArmy.Location == Dummy3){
				// Tell the player to settle here now!
				Message (g.player, 'WWSettleNow');
				DisableTrigger('WWMoveUnits_F');
			}
					
		}
		elseif(isCityThere == 0){
			if(tmpArmy.Location == Dummy | | tmpArmy.Location == Dummy2 | | tmpArmy.Location == Dummy3){
				// Tell the player to destroy city then settle here
				Message (g.player, 'WWDestroySettle');
				DisableTrigger('WWMoveUnits_F'); 
			}
		}
	}	
}

---

I would be very,very,very,very,very,very,very,very,very,very,very,very, grateful if someone could help me, as this scenario is really beginning to take shape (well the code that is )

heardie - head hurting because he has banged it against the desk so many times tonight!

code:

---

HandleEvent(CreateCity) 'WWCreateCity2_F' post {
     if(CityIsValid(city[0])) {
             if(city0].location == Dummy3){                 
                     if(turnCount <= 203 ){
                             playerScore = playerScore + 1000;  // Max Score!!
                             Message (g.player, 'WWCityBuilt');
                     }
                     elseif(turnCount > 204){
                             playerScore = playerScore + 750;
                             Message (g.player, 'WWCityBuilt2');
                     }
                     elseif(turnCount > 307){
                             playerScore = playerScore + 500;
                             Message (g.player, 'WWCityBuilt3');
                     }
                     hasCity = 1 ;
             }
     }            
}

---

1) Basicly all Jerk said about #1, but I have a few minor additions. For one thing, a function returns values, a eventhandler can only return STOP or CONTINUE and the CONTINUE is the default return-'value', so the else-part of his code can be left out (or at least 0 should be replaced with CONTINUE). Also, the first of Jerk's solutions covers the city from goody hut scenario so I'd go for that one if there are/might be goody huts on that location. However, I'm not sure if stopping the CreateCity event will kill the settler, but I'm fairly confident that stopping the Settle event won't kill it, so if you don't care about the goody hut for some reason, that would probably be the best way to go (though I'd test to make sure it won't kill the Settler if I were you).

2) For number two the same situation applies: no need to cycle through all units, simply use the existing built-in variables, so it looks something like this:

(BTW, I assumed that turnCount is the number of turns from the beginning of the game and the game starts in turn 0; in this case g.year is exactly the same but slightly more efficient)

code:

---

HandleEvent(CreateCity) 'WWCreateCity2_F' post {
city_t	tmpCity;
	tmpCity = city[0];
	if (city[0].location == Dummy3) {
		if (g.year > 307) {	// if g.year > 307 then it's also > 101, so order needs to be reversed
			playerScore = playerScore + 500;
			hasCity = 1;
			Message (tmpCity.owner, 'WWCityBuilt2');
		} elseif (g.year > 204) {
			playerScore = playerScore + 750;
			hasCity = 1;
			Message (tmpCity.owner, 'WWCityBuilt2');
		} elseif (g.year > 101) {	
			playerScore = playerScore + 1000;
			hasCity = 1;
			Message (tmpCity.owner, 'WWCityBuilt');
		}
	}
}

---

3) Again, don't set player[0] to 0, rather set player[2] to army[0].owner or something (some player[x] that can't possibly contain an important value at that moment). Other than that, it looks like it should work:

code:

---

HandleEvent(MoveUnits) 'WWMoveUnits_F' post {
int_t	i;
army_t	tmpArmy;
	player[2] = army[0].owner;
	for (i = 0; i < player[2].armies; i = i + 1) {
		GetArmyByIndex(player[2], i, tmpArmy);
		if (tmpArmy.location == Dummy | | tmpArmy.location == Dummy2 | | tmpArmy.location == Dummy3) {
			if (isCityThere) {	// 1 = true, 0 = false, so '== [1|0]' not needed
				Message(player[2], 'WWSettleNow');
				DisableTrigger('WWMoveUnits_F');
			} else {
				Message(player[2], 'WWDestroySettle');
				DisableTrigger('WWMoveUnits_F');
			}
		}
	}
}

---

What I find odd is that only one player gets this message on only one of the locations and and after that, the trigger is disabled (you may want to make one version for every player and add a 'if (IsHumanPlayer(player[2])) {' somewhere as well. Also strange is that you tell people to settle at Dummy or Dummy2, yet if they try this, it's not allowed. Of course I don't know what you're trying to do so I could be all wrong, but it all seems rather odd to me.

When I tested stopping createcity it did kill the settler on me, I left it open (removed the comparing of the locations so it would work on every createcity) and quickly ended my game since it was the first turn and my only unit (the settler) was dead
To add the unit back after you can change it to something like:

code:

---

HandleEvent(CreateCity) 'WWCreateCity_F' pre {
        if (location[0] == Dummy | | location[0] == Dummy2){
                Message (player[0], 'WWTerrainRecommend');
                // Since returning STOP will kill the unit attempting to create the city
                // You must recreate the unit (i suppose this can be a nifty way of healing 
                // the settler but oh well)
                if (value[0] == 1 && value[1] > -1) {
                     CreateUnit(player[0], value[1], location[0], 0);
                }
                return STOP;
        }
}

---

Now index 2 comes from the pllayer[2] bit im guessing.

What does the error mean and how do you fix it?